feat: add Weak Credential tester for Apache Hive #490

W0ngL1 · 2024-05-26T07:32:11Z

Hi @maoning,
PR for AI PRP: Request Weak Credential tester for Apache

And the PR for dependents of hive-jdbc is google/tsunami-security-scanner#113, PR for testbeds is google/security-testbeds#58

leonardo-doyensec

Hi @W0ngL1.
Thank you for your contribution. You can find all the issues to address down below. I'm also noticing that the plugin is a bit slow to run, i think that this is due to jdbc, but i'm not 100% sure of that. Can you please check it?

Feel free to reach out
~ Leonardo(Doyensec)

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

...tectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTesterTest.java

leonardo-doyensec

Thank you for your quick changes @W0ngL1. You can find some issues to address down below.
Moreover i'm noticing, while running the plugin, a series of error related to logging. The output is the following. Can you please investigate into it?

ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

...tectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTesterTest.java

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

W0ngL1 · 2024-07-12T03:06:14Z

Thank you for your quick changes @W0ngL1. You can find some issues to address down below. Moreover i'm noticing, while running the plugin, a series of error related to logging. The output is the following. Can you please investigate into it?

ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.

Hi @leonardo-doyensec, It's ok when I run it, can you try again? It seems to be caused by logger, I removed it.

leonardo-doyensec

Thank you @W0ngL1. You can find some issues to address down below.

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

...tectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTesterTest.java

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

W0ngL1 · 2024-07-13T09:05:08Z

Hi @leonardo-doyensec, please review again if you're free :)

leonardo-doyensec · 2024-07-30T15:04:48Z

Thank you for your changes @W0ngL1.
I'm noticing that, on my side, the plugin is not working anymore. Can you please confirm that, on your side, everything is working fine?

Feel free to reach out
~ Leonardo (Doyensec)

W0ngL1 · 2024-07-31T03:55:38Z

Sorry for that @leonardo-doyensec. I've fixed it and tested it.

$ java -cp "./tsunami-security-scanner/main/build/libs/tsunami-main-0.0.23-SNAPSHOT-cli.jar:./tsunami-security-scanner-plugins/google/detectors/credentials/generic_weak_credential_detector/build/libs/*" com.google.tsunami.main.cli.TsunamiCli --ip-v4-target=127.0.0.1 --port-ranges-target=10002
...
com.google.tsunami.plugins.detectors.credentials.genericweakcredentialdetector.testers.hive.HiveCredentialTester isHiveAccessible
INFO: url: jdbc:hive2://127.0.0.1:10000/default, username: test, password: test
com.google.tsunami.plugins.detectors.credentials.genericweakcredentialdetector.testers.hive.HiveCredentialTester isHiveAccessible
INFO: Connected to the Hive server successfully.
...
Port scanning phase (15.44 s) with 1 plugin(s):
    /Tsunami Team ([email protected])/PORT_SCAN/NmapPortScanner/0.1
  Service fingerprinting phase (201.3 ms) with 0 plugin(s):

  Vuln detection phase (19.06 s) with 1 plugin(s):
    /Tsunami Team ([email protected])/VULN_DETECTION/GenericCredentialDetectorPlugin/0.1 was selected for the following services: documentum (TCP, port 10002)
  # of detected vulnerability: 1.
...

leonardo-doyensec · 2024-08-12T13:42:22Z

Hi @W0ngL1.
I confirm that now the plugin is working correctly. However i notice one more verbose error message during the tsunami scan.

Seems like that this error appears when using an empty password during the bruteforce.
Can you please take a look at it?

ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
ERROR StatusLogger Unrecognized format specifier [d]
ERROR StatusLogger Unrecognized conversion specifier [d] starting at position 16 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [thread]
ERROR StatusLogger Unrecognized conversion specifier [thread] starting at position 25 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [level]
ERROR StatusLogger Unrecognized conversion specifier [level] starting at position 35 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [logger]
ERROR StatusLogger Unrecognized conversion specifier [logger] starting at position 47 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [msg]
ERROR StatusLogger Unrecognized conversion specifier [msg] starting at position 54 in conversion pattern.
ERROR StatusLogger Unrecognized format specifier [n]
ERROR StatusLogger Unrecognized conversion specifier [n] starting at position 56 in conversion pattern.

W0ngL1 · 2024-08-29T08:30:47Z

Hi @leonardo-doyensec, I reproduced the problem, when I delete an empty username and password, the problem still persists.

It seems to be related to log4j configuration, and I cannot find the corresponding configuration files in the scanner and plugins projects, so I cannot hide these lines of error unfortunately.

However, it does not affect the actual effect, would you consider ignoring this small issue?

leonardo-doyensec · 2024-09-30T13:18:57Z

LGTM - Approved
@maoning we can merge this. Moreover we can also merge the google/security-testbeds#58

Reviewer: Leonardo, Doyensec
Plugin: Weak Credentials Apache Hive
Feedback: The overall quality is decent. The security testbed was fairly easy to deploy. The plugin was lacking a fingerprinting phase and some minor aspect of formatting went overlooked. The contributor was really fast to address all the issues.
Drawback: None.

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java

…ce) instead of the whole buildTargetUrl function

W0ngL1 · 2024-10-23T03:29:34Z

Hi @tooryx, l've updated.

feat: add Weak Credential tester for Apache Hive

76058d7

leonardo-doyensec reviewed Jul 9, 2024

View reviewed changes

leonardo-doyensec self-assigned this Jul 9, 2024

W0ngL1 added 2 commits July 9, 2024 22:37

chore: format

8cbcbbf

feat: add http detection for apache hive

01f991f

W0ngL1 force-pushed the dev_hive branch from 8add20e to 01f991f Compare July 10, 2024 07:24

leonardo-doyensec reviewed Jul 11, 2024

View reviewed changes

W0ngL1 added 3 commits July 12, 2024 09:47

chore: format

43df9f5

feat: return hive detection results directly through HTTP response

7f7a034

chore: remove debug log

121e4a4

chore: remove useless variables and imports

390fac6

leonardo-doyensec reviewed Jul 12, 2024

View reviewed changes

W0ngL1 added 3 commits July 12, 2024 22:51

chore: format

1956153

feat: update

e1a1907

chore: format

4d67ac8

tooryx linked an issue Jul 26, 2024 that may be closed by this pull request

AI PRP: Request Weak Credential tester for Apache Hive #418

Closed

W0ngL1 added 2 commits July 31, 2024 10:08

Merge branch 'google:master' into dev_hive

251975c

fix: failed to build target url

00bcc87

tooryx added the Contributor main The main issue a contributor is working on (top of the contribution queue). label Aug 6, 2024

tooryx added the lgtm label Sep 30, 2024

tooryx reviewed Oct 22, 2024

View reviewed changes

...s/detectors/credentials/genericweakcredentialdetector/testers/hive/HiveCredentialTester.java Outdated Show resolved Hide resolved

feat: use NetworkServiceUtils.buildWebApplicationRootUrl(networkServi…

4193d5a

…ce) instead of the whole buildTargetUrl function

copybara-service bot merged commit c663072 into google:master Oct 24, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Weak Credential tester for Apache Hive #490

feat: add Weak Credential tester for Apache Hive #490

W0ngL1 commented May 26, 2024 •

edited

Loading

leonardo-doyensec left a comment

leonardo-doyensec left a comment

W0ngL1 commented Jul 12, 2024 •

edited

Loading

leonardo-doyensec left a comment

W0ngL1 commented Jul 13, 2024

leonardo-doyensec commented Jul 30, 2024

W0ngL1 commented Jul 31, 2024 •

edited

Loading

leonardo-doyensec commented Aug 12, 2024

W0ngL1 commented Aug 29, 2024 •

edited

Loading

leonardo-doyensec commented Sep 30, 2024 •

edited

Loading

W0ngL1 commented Oct 23, 2024

feat: add Weak Credential tester for Apache Hive #490

feat: add Weak Credential tester for Apache Hive #490

Conversation

W0ngL1 commented May 26, 2024 • edited Loading

leonardo-doyensec left a comment

Choose a reason for hiding this comment

leonardo-doyensec left a comment

Choose a reason for hiding this comment

W0ngL1 commented Jul 12, 2024 • edited Loading

leonardo-doyensec left a comment

Choose a reason for hiding this comment

W0ngL1 commented Jul 13, 2024

leonardo-doyensec commented Jul 30, 2024

W0ngL1 commented Jul 31, 2024 • edited Loading

leonardo-doyensec commented Aug 12, 2024

W0ngL1 commented Aug 29, 2024 • edited Loading

leonardo-doyensec commented Sep 30, 2024 • edited Loading

W0ngL1 commented Oct 23, 2024

W0ngL1 commented May 26, 2024 •

edited

Loading

W0ngL1 commented Jul 12, 2024 •

edited

Loading

W0ngL1 commented Jul 31, 2024 •

edited

Loading

W0ngL1 commented Aug 29, 2024 •

edited

Loading

leonardo-doyensec commented Sep 30, 2024 •

edited

Loading