Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved implementation of Spark CVE-2022-33891 detector #594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lokiuox
Copy link
Collaborator

@lokiuox lokiuox commented Feb 7, 2025

The previous implementation was prone to false positives as, in absence of the Callback Server, it would resort to just measuring the time taken by the HTTP response.

The following modifications were done in accordance with the Tsunami team:

  • The detector can now only run when the Callback Server is available. The time-measuring branch was removed.
  • Implemented a small fingerprinting step
  • Added a 5s delay before the callback server is polled to account for slow targets
  • Fixed the tests accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant