Add ruby formatting support using Rubocop. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
reviewed
May 27, 2023
dbarnett
reviewed
May 27, 2023
dbarnett
reviewed
May 28, 2023
dbarnett
reviewed
May 28, 2023
This change is based on an abandoned change by zinovyev: https://github.com/zinovyev/vim-codefmt/tree/add-support-for-ruby and matching pull request: #132
…th older versions of vim
dbarnett
reviewed
Jun 1, 2023
| call maktaba#ensure#IsNumber(a:startline) | ||
| call maktaba#ensure#IsNumber(a:endline) | ||
|
|
||
| let l:ignoreerrors = a:0 >= 1 ? a:1 : 0 |
There was a problem hiding this comment.
Fun fact: You can also do let l:ignoreerrors = get(a:, 1, 0) for the same effect, slightly more cryptic but a bit more literal once you're used to the syntax.
Either way works fine here though, and I'm focused on getting this PR merged quickly after all the delays. =)
dbarnett
approved these changes
Jun 1, 2023
dbarnett
added a commit
that referenced
this pull request
Jun 2, 2023
dbarnett
added a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #30
This change is based on an abandoned change by zinovyev:
https://github.com/zinovyev/vim-codefmt/tree/add-support-for-ruby
and matching pull request:
#132
I've added code comments to resolve dbarnett's question from that review, and added vroom tests.