-
Notifications
You must be signed in to change notification settings - Fork 68
Android supports 16KB page size #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This page makes it sound like this should be done by setting |
@emersion Thank you for the excellent suggestion! I've updated the implementation to follow the official Android guidelines you referenced. |
Nice! I wonder, do we need to set it twice (one time in the CMake file, another time in the Gradle file)? Isn't one time enough? |
@emersion You're right! The CMakeLists.txt setting was redundant since build.gradle already passes this configuration to CMake. Removed the duplicate line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
Doesn't have the build.gradle be adapted further? I only passed the warning in google play console after additionally adjusting this in the webcrypto build.gradle: dependencies { in "android": setting ndkVersion '28.2.13676358' and compileSdkVersion 36 After that, building a release bundle with your pullrequest branch included in my project as a dependency override, finally the warning in the play console went away. |
@seriousGeorgeFX Thanks for sharing! Those configurations should be handled by the consuming application, not the library itself. As a Flutter plugin, webcrypto should maintain backward compatibility. |
Add 16 KB page size compatibility
https://developer.android.com/guide/practices/page-sizes?hl=zh-tw
#207