Skip to content

Conversation

wyqlxf
Copy link

@wyqlxf wyqlxf commented Aug 25, 2025

@emersion
Copy link
Contributor

This page makes it sound like this should be done by setting ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON for Android NDK r27 (Flutter's default version):
https://developer.android.com/guide/practices/page-sizes#compile-r27

@wyqlxf
Copy link
Author

wyqlxf commented Sep 22, 2025

@emersion Thank you for the excellent suggestion! I've updated the implementation to follow the official Android guidelines you referenced.

@emersion
Copy link
Contributor

Nice! I wonder, do we need to set it twice (one time in the CMake file, another time in the Gradle file)? Isn't one time enough?

@wyqlxf
Copy link
Author

wyqlxf commented Sep 23, 2025

@emersion You're right! The CMakeLists.txt setting was redundant since build.gradle already passes this configuration to CMake. Removed the duplicate line.

Copy link
Contributor

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@seriousGeorgeFX
Copy link

Doesn't have the build.gradle be adapted further? I only passed the warning in google play console after additionally adjusting this in the webcrypto build.gradle:

dependencies {
classpath 'com.android.tools.build:gradle:8.6.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:2.2.0"
}

in "android": setting ndkVersion '28.2.13676358' and compileSdkVersion 36
in "defaultconfig": setting minSdkVersion 23

After that, building a release bundle with your pullrequest branch included in my project as a dependency override, finally the warning in the play console went away.

@wyqlxf
Copy link
Author

wyqlxf commented Sep 29, 2025

@seriousGeorgeFX Thanks for sharing! Those configurations should be handled by the consuming application, not the library itself. As a Flutter plugin, webcrypto should maintain backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants