Avoid copying interp-values in EvalCreateTuple

This could cause significant memory use. Fixes: #1897 PiperOrigin-RevId: 721862074
google · Jan 31, 2025 · 432f5e6 · 432f5e6
1 parent bcdfc12
commit 432f5e6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/xls/dslx/bytecode/bytecode_interpreter.cc b/xls/dslx/bytecode/bytecode_interpreter.cc
@@ -762,12 +762,12 @@ absl::Status BytecodeInterpreter::EvalCreateTuple(const Bytecode& bytecode) {
   elements.reserve(tuple_size.value());
   for (int64_t i = 0; i < tuple_size.value(); i++) {
     XLS_ASSIGN_OR_RETURN(InterpValue value, Pop());
-    elements.push_back(value);
+    elements.push_back(std::move(value));
   }
 
   std::reverse(elements.begin(), elements.end());
 
-  stack_.Push(InterpValue::MakeTuple(elements));
+  stack_.Push(InterpValue::MakeTuple(std::move(elements)));
   return absl::OkStatus();
 }