Skip to content

Commit

Permalink
Fix a couple of missing includes.
Browse files Browse the repository at this point in the history
The latest absl is more well-layered and helps finding that
str_cat.h was not always included.

PiperOrigin-RevId: 604483106
  • Loading branch information
hzeller authored and copybara-github committed Feb 6, 2024
1 parent e5095de commit 8bbf1b2
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 3 deletions.
8 changes: 5 additions & 3 deletions xls/examples/jpeg/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

load("@rules_hdl//verilog:providers.bzl", "verilog_library")
load("@rules_hdl//static_timing:build_defs.bzl", "run_opensta")
load("@rules_hdl//synthesis:build_defs.bzl", "synthesize_rtl")
load(
"//xls/build_rules:xls_build_defs.bzl",
"cc_xls_ir_jit_wrapper",
Expand All @@ -23,9 +26,6 @@ load(
"xls_ir_verilog_fdo",
"xls_synthesis_metrics",
)
load("@rules_hdl//verilog:providers.bzl", "verilog_library")
load("@rules_hdl//synthesis:build_defs.bzl", "synthesize_rtl")
load("@rules_hdl//static_timing:build_defs.bzl", "run_opensta")

package(
default_applicable_licenses = ["//:license"],
Expand Down Expand Up @@ -204,7 +204,9 @@ cc_library(
hdrs = ["streams.h"],
deps = [
":constants",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/strings:str_format",
"//xls/common/logging",
"//xls/common/status:ret_check",
Expand Down
6 changes: 6 additions & 0 deletions xls/examples/jpeg/streams.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,22 @@

#include "xls/examples/jpeg/streams.h"

#include <climits>
#include <cstdint>
#include <functional>
#include <optional>
#include <string>
#include <string_view>
#include <utility>
#include <vector>

#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/str_format.h"
#include "xls/common/logging/logging.h"
#include "xls/common/status/ret_check.h"
#include "xls/common/status/status_macros.h"
#include "xls/examples/jpeg/constants.h"

namespace xls::jpeg {
Expand Down
2 changes: 2 additions & 0 deletions xls/ir/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,9 @@ cc_library(
hdrs = ["channel_ops.h"],
deps = [
"//xls/common/logging",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
],
)

Expand Down
4 changes: 4 additions & 0 deletions xls/ir/channel_ops.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,14 @@

#include "xls/ir/channel_ops.h"

#include <cstdint>
#include <ostream>
#include <string>
#include <string_view>

#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_cat.h"
#include "xls/common/logging/logging.h"

namespace xls {
Expand Down
4 changes: 4 additions & 0 deletions xls/ir/ir_scanner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@

#include "xls/ir/ir_scanner.h"

#include <cctype>
#include <cstdint>
#include <functional>
#include <optional>
#include <string>
#include <string_view>
#include <utility>
#include <vector>

#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/ascii.h"
#include "absl/strings/str_format.h"
#include "absl/strings/str_cat.h"
#include "xls/common/logging/logging.h"
#include "xls/common/status/status_macros.h"
#include "xls/ir/number_parser.h"
Expand Down

0 comments on commit 8bbf1b2

Please sign in to comment.