Skip to content

Commit

Permalink
[DSLX:cleanup] Move builtins X-macro to dslx_builtins translation unit.
Browse files Browse the repository at this point in the history
This requires us to move signatures out to a different translation unit to
avoid a circular dependency with interpreter values.

PiperOrigin-RevId: 615595496
  • Loading branch information
cdleary authored and copybara-github committed Mar 14, 2024
1 parent ad44fe2 commit ee7921b
Show file tree
Hide file tree
Showing 10 changed files with 1,299 additions and 1,236 deletions.
16 changes: 14 additions & 2 deletions xls/dslx/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ cc_library(
srcs = ["interp_value.cc"],
hdrs = ["interp_value.h"],
deps = [
":dslx_builtins",
":value_format_descriptor",
"//xls/common:math_util",
"//xls/common/logging",
Expand Down Expand Up @@ -371,6 +372,19 @@ cc_library(
name = "dslx_builtins",
srcs = ["dslx_builtins.cc"],
hdrs = ["dslx_builtins.h"],
deps = [
"@com_google_absl//absl/base:no_destructor",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings:str_format",
],
)

cc_library(
name = "dslx_builtins_signatures",
srcs = ["dslx_builtins_signatures.cc"],
hdrs = ["dslx_builtins_signatures.h"],
deps = [
":channel_direction",
":errors",
Expand All @@ -392,8 +406,6 @@ cc_library(
"@com_google_absl//absl/base:no_destructor",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/strings:str_format",
Expand Down
Loading

0 comments on commit ee7921b

Please sign in to comment.