[c_api] Public API for DSLX to IR w/ warning knobs. #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
changed the title
cdleary
force-pushed
the
cdleary/2025-02-06-warnings-passed-to-c-api
branch
2 times, most recently
from
9a13f46 to
ca4c7d8
Compare
grebe
requested changes
Feb 11, 2025
cdleary
force-pushed
the
cdleary/2025-02-06-warnings-passed-to-c-api
branch
from
ca4c7d8 to
1fa1376
Compare
grebe
approved these changes
Feb 12, 2025
cdleary
force-pushed
the
cdleary/2025-02-06-warnings-passed-to-c-api
branch
2 times, most recently
from
df58075 to
0208954
Compare
Exposes warning data through the C API boundary.
cdleary
force-pushed
the
cdleary/2025-02-06-warnings-passed-to-c-api
branch
from
0208954 to
a76e87f
Compare
|
All comments addressed now, thanks. |
grebe
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the prior C APIs but adds the versions that take warning parameters as well.
Note that the /public C++ API/ is changed so that we can consolidate a bit vs having APIs with tons of parameters on that side of the equation -- we're not going for a flat "C ABI style" design there. This will require a global check on import.
Adds:
xls_convert_dslx_path_to_ir_with_warningsto supplementxls_convert_dslx_path_to_irxls_convert_dslx_to_ir_with_warningsto supplementxls_convert_dslx_to_irxls_c_strs_freeto free the dynamically sized warnings array that can be returned from the API