Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: move npm link around to try to fix dependency loop #1707

Merged
merged 3 commits into from
Feb 28, 2025
Merged

tests: move npm link around to try to fix dependency loop #1707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7435e4
tests: move npm link around to try to fix dependency loop
feywind Feb 28, 2025
401b249
Merge branch 'main' into logging-samples-link
feywind Feb 28, 2025
3a95e9e
tests: more moving npm link around
feywind Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion logging-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"fix": "gts fix",
"prepare": "npm run compile",
"precompile": "gts clean",
"samples-test": "cd samples/ && npm install && npm test && cd ../",
"samples-test": "cd samples/ && npm install && npm link ../ && npm test && cd ../",
"system-test": "echo no system tests 🙀"
},
"author": "Google API Authors",
Expand Down
5 changes: 2 additions & 3 deletions logging-utils/samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"pretest": "npm run compile",
"compile": "tsc -p .",
"typeless": "npx typeless-sample-bot --outputpath javascript --targets typescript --recursive",
"posttypeless": "npx eslint --fix javascript",
"preinstall": "npm link ../"
"posttypeless": "npx eslint --fix javascript"
},
"files": [
"javascript/*.js",
Expand All @@ -27,7 +26,7 @@
"node": ">=14"
},
"dependencies": {
"google-logging-utils": "^1.0.1"
"google-logging-utils": "1.0.1"
},
"devDependencies": {
"@google-cloud/typeless-sample-bot": "^2.1.0",
Expand Down
Loading