Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-export logging utils from gax #1718

Merged
merged 6 commits into from
Mar 10, 2025
Merged

Conversation

feywind
Copy link
Contributor

@feywind feywind commented Mar 6, 2025

Export the logging package from gax so gapics can use it without adding to their package.json.

@feywind feywind requested review from a team as code owners March 6, 2025 20:36
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 6, 2025
sofisl
sofisl previously approved these changes Mar 6, 2025
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Mar 6, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 6, 2025
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 7, 2025
@feywind feywind added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 10, 2025
@gcf-merge-on-green gcf-merge-on-green bot dismissed sofisl’s stale review March 10, 2025 18:28

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 363ae57 into main Mar 10, 2025
27 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 10, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the gax-repub-logging branch March 10, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants