fix: update toolset attributes naming and closing of stdio/sse spans

[AjmeraParth132]

Description

Updated toolset.name attribute uniformly across metrics and spans. Also, updated session_id to mcp.session.id attribute - as in the semantic convention

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

• Make sure you reviewed
  CONTRIBUTING.md
• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)
• Make sure to add ! if this involve a breaking change

🛠️ Fixes #2222

[gemini-code-assist]

Summary of Changes

Hello @AjmeraParth132, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the naming of OpenTelemetry span attributes to adhere to established semantic conventions. Specifically, it unifies the toolset.name attribute and renames session_id to mcp.session.id, improving consistency and compliance with tracing standards for better observability.

Highlights

• Attribute Naming Convention: Standardized the toolset_name attribute to toolset.name across all relevant span creations for consistency with OpenTelemetry semantic conventions.
• Session ID Attribute Update: Updated the session_id attribute to mcp.session.id to align with OpenTelemetry semantic conventions for session identification.

Changelog

• internal/server/api.go
  • Updated toolset_name attribute to toolset.name.
• internal/server/mcp.go
  • Updated session_id attribute to mcp.session.id.
  • Updated toolset_name attribute to toolset.name.
• internal/server/server.go
  • Updated toolset_name attribute to toolset.name.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully updates the naming conventions for toolset and session_id attributes across various files (api.go, mcp.go, server.go). The changes align with the OpenTelemetry semantic conventions, using dot notation (toolset.name) and adding a prefix for session ID (mcp.session.id). This improves consistency and maintainability of the tracing and metrics attributes. The changes are well-implemented and directly address the stated goal of the pull request.

[Yuan325]

/gcbrun