Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Move Base AuthClient Types to authclient.ts #1774

Merged
merged 5 commits into from
Feb 1, 2025
Merged

refactor!: Move Base AuthClient Types to authclient.ts #1774

merged 5 commits into from
Feb 1, 2025

Conversation

HubertJan
Copy link
Contributor

Fixes #1773 🦕

@HubertJan HubertJan requested review from a team as code owners March 12, 2024 23:04
@google-cla Google CLA
Copy link

google-cla bot commented Mar 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 12, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Mar 12, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@HubertJan HubertJan force-pushed the HubertJan-chore/move-base-authclient-types branch 2 times, most recently from 939980e to ed5c763 Compare March 12, 2024 23:18
@HubertJan HubertJan force-pushed the HubertJan-chore/move-base-authclient-types branch from ed5c763 to 6232a14 Compare March 12, 2024 23:20
danielbankhead
danielbankhead approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@danielbankhead danielbankhead added do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version labels Mar 13, 2024
@HubertJan
Copy link
Contributor Author

The linter was failing, I fixed that now. I hope we can merge now :)

@danielbankhead
Copy link
Contributor

@HubertJan thanks! We'll merge it in the next major

@d-goog d-goog requested a review from a team as a code owner February 1, 2025 03:23
@d-goog d-goog removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 1, 2025
@d-goog d-goog merged commit b0c3a43 into googleapis:main Feb 1, 2025
12 checks passed
@release-please release-please bot mentioned this pull request Feb 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@d-goog d-goog d-goog approved these changes

Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor!: Move Base AuthClient Types to authclient.ts
3 participants
@HubertJan @danielbankhead @d-goog