Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable Universe Domain Check #1878

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

danielbankhead
Copy link
Contributor

Temporarily Disable Universe Domain Check for MDS by default

🦕

@danielbankhead danielbankhead requested review from a team as code owners October 3, 2024 18:55
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 3, 2024
@bd-nweinstein
Copy link

bd-nweinstein commented Mar 10, 2025

Hi there, I'm curious why this was disabled? Is there an associated issue? I think I'm encountering a bug caused by the code before this change (I'm on google-auth-library 9.4.1) where my app running in GKE randomly fails to connect to bigquery or firestore with the error

Error: Invalid response from metadata service: incorrect Metadata-Flavor header.

It seems as though my metadata server does not return this header when universe_domain is queried from the pod in my gke cluster:

curl -v -H "Metadata-Flavor: Google" http://169.254.169.254/computeMetadata/v1/universe/universe_domain
*   Trying 169.254.169.254:80...
* Connected to 169.254.169.254 (169.254.169.254) port 80 (#0)
> GET /computeMetadata/v1/universe/universe_domain HTTP/1.1
> Host: 169.254.169.254
> User-Agent: curl/7.88.1
> Accept: */*
> Metadata-Flavor: Google
> 
< HTTP/1.1 200 OK
< Content-Type: application/text
< ETag: 23d0ca25faab0f19
< Date: Mon, 10 Mar 2025 13:13:14 GMT
< Server: Metadata Server for VM
< Content-Length: 14
< X-XSS-Protection: 0
< X-Frame-Options: SAMEORIGIN
< 
* Connection #0 to host 169.254.169.254 left intact
googleapis.com

So, probably my issue was caused by #1745 ?

@ernestoalejo
Copy link

@bd-nweinstein I think we have the same issue: #1946

@mssodhi
Copy link

mssodhi commented Mar 10, 2025

@bd-nweinstein @ernestoalejo we're also experiencing the same issue, but using pubsub. Randomly started getting Error: Invalid response from metadata service: incorrect Metadata-Flavor header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants