-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(check-api): use abi-dumper w/ integer overflow fix #7098
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7098 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 1308 1308
Lines 112974 112974
=======================================
+ Hits 106754 106756 +2
+ Misses 6220 6218 -2
Continue to review full report at Codecov.
|
Should we leave a note to ourselves to revert this when Fedora picks up the fix? |
Done. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Pulls in the fix from lvc/abi-dumper#29
This will remove log spew that looks like:
Example:
GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/cb9409ba-1ccc-47ae-a233-01c6ebe8f075;tab=detail?project=cloud-cpp-testing-resources
Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/017cddfefc34c1a2a4c750bd58468dc3b06ae3eb/fedora-34-check-api/log-cb9409ba-1ccc-47ae-a233-01c6ebe8f075.txt
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)