Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(check-api): use abi-dumper w/ integer overflow fix #7098

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Aug 2, 2021

@devjgm devjgm requested a review from a team as a code owner August 2, 2021 18:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3d6461adc14a26e923d27efdac2c607c9a84757e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #7098 (4d605cd) into main (88f748c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7098   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files        1308     1308           
  Lines      112974   112974           
=======================================
+ Hits       106754   106756    +2     
+ Misses       6220     6218    -2     
Impacted Files Coverage Δ
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f748c...4d605cd. Read the comment docs.

@devbww
Copy link
Contributor

devbww commented Aug 2, 2021

Should we leave a note to ourselves to revert this when Fedora picks up the fix?

@devjgm
Copy link
Contributor Author

devjgm commented Aug 2, 2021

Should we leave a note to ourselves to revert this when Fedora picks up the fix?

Done.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7ce9a6665e4c61625dfb7fb02dc8f68210a63af7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4d605cd6de5487babd076e9542d621c822db77c9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devjgm devjgm merged commit d72883a into googleapis:main Aug 2, 2021
@devjgm devjgm deleted the new-abi-dumper branch August 2, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants