Skip to content

Conversation

@chingor13
Copy link
Contributor

Towards #2800

@chingor13 chingor13 requested a review from ldetmer November 5, 2025 19:07
@chingor13 chingor13 requested a review from a team as a code owner November 5, 2025 19:07
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chingor13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational infrastructure and automation logic to enable a new update-image command within the librarian system. It establishes Google Cloud Build configurations to orchestrate the end-to-end process of updating images, encompassing repository cloning, Git configuration, and the execution of the librarian tool. This enhancement aims to streamline and automate the image update workflow by integrating it seamlessly into the existing automation framework.

Highlights

  • New GCB Configurations: Two new Google Cloud Build configurations (update-image.yaml and update-image-worker.yaml) have been added to support an update-image operation within the librarian system.
  • Update Image Command Integration: The update-image command is now recognized as an available command within the internal automation system, allowing it to be triggered and managed.
  • Automated Image Update Workflow: The new GCB configuration for update-image defines a multi-step process including cloning language repositories, configuring Git user details, cloning the googleapis repository, and executing the librarian update-image command with necessary parameters and secret management.
  • Build Parameter Propagation: The _BUILD substitution variable is now correctly passed to the update-image command, aligning its behavior with the existing generate command for consistent build context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Google Cloud Build configurations for a new update-image command. The changes look good overall, but I've found a few issues. There are some inaccurate comments in the new YAML files that should be corrected for clarity. More importantly, there's a critical bug in internal/automation/trigger.go where the new update-image command is not registered, which will prevent it from running. I've also suggested a small improvement in one of the build configurations to use the main branch instead of master for better future compatibility.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.55%. Comparing base (be56755) to head (41ff61a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
+ Coverage   86.50%   86.55%   +0.04%     
==========================================
  Files         120      120              
  Lines       10232    10299      +67     
==========================================
+ Hits         8851     8914      +63     
- Misses        977      979       +2     
- Partials      404      406       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chingor13 chingor13 requested a review from ldetmer November 5, 2025 19:58
@chingor13 chingor13 merged commit 2f8457f into main Nov 5, 2025
9 checks passed
@chingor13 chingor13 deleted the update-image-gcb branch November 5, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants