-
Notifications
You must be signed in to change notification settings - Fork 32
build(librarian): add GCB configs for update-image #2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chingor13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational infrastructure and automation logic to enable a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Google Cloud Build configurations for a new update-image command. The changes look good overall, but I've found a few issues. There are some inaccurate comments in the new YAML files that should be corrected for clarity. More importantly, there's a critical bug in internal/automation/trigger.go where the new update-image command is not registered, which will prevent it from running. I've also suggested a small improvement in one of the build configurations to use the main branch instead of master for better future compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
+ Coverage 86.50% 86.55% +0.04%
==========================================
Files 120 120
Lines 10232 10299 +67
==========================================
+ Hits 8851 8914 +63
- Misses 977 979 +2
- Partials 404 406 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Towards #2800