font-tags: turn into local webapp #1013
Conversation
|
I don't think we want users to run python, just give them a url. github pages (ala https://rsheeter.github.io/android_fonts/emoji.html?q=) or even codepen (poc https://codepen.io/rs42/pen/mdZwdZM) seems likely to be sufficient unless there is some capability that requires python? |
| console.error('Error:', error); | ||
| }); | ||
| }, | ||
| loadCSV() { |
There was a problem hiding this comment.
Can this be redone to use the Github API?
Well, the workflow Marc actually has is editing the file locally, so, in the httpd() call he has,
But all the py code is doing is loading the CSV and serving it via a httpd; this is useful for a local workflow since then the file is edited and can be directly committed. For a github pages version, I think "all" Marc has to do is use the Github API (using something like https://github.com/elwayman02/ember-data-github) to load and commit the tags csv file directly. (Your plain js codepen example is good for loading the file, but presents a workflow challenge.) Both workflows are worth supporting, imo |
|
I would just let the user download either an updated file or a diff to use for a PR. That simplifies things and is a major improvement over the spreadsheet workflow. Most of the benefit at very low cost, near-0 maintenance because there are no dependencies or scary operations. |
|
SGTM. I'll drop the server and just host it on the google/fonts gh-pages. |
|
MVP :) |
+1. Launch, begin to capture value, and iterate. |
|
Closing since this has moved to google/fonts, https://google.github.io/fonts/tags.html |
The spreadsheets have become a nightmare to maintain so I've created a webapp that users run locally to edit font tags instead. The app works directly on the tagging csv so we can drop the spreadsheets.
To use the app run
gftools font-tags path/to/google/fonts