Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support py3.13 #1058

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Support py3.13 #1058

merged 4 commits into from
Nov 14, 2024

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Nov 5, 2024

I'll probably have to update the packager which I'll do tomorrow. I think Blackrender also has an issue so I'll check that out as well.

Thanks @thundernixon

Will fix #1050

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 5, 2024

I should drop py3.8 as well.

@m4rc1e m4rc1e changed the title fix pygit2 fail Support py3.13 Nov 5, 2024
Drop 3.8 since it is end of life and add 3.13
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 6, 2024

This pr currently supports pip install gftools for py3.9-3.13. It doesn't work for py3.13 with the qa additions, pip install gftools[qa]. We need to wait for a new release of skia-python, kyamagu/skia-python#275 (comment)

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 6, 2024

I'm going to merge this since it is in a better condition for py3.13 support than before. Once the new skia-python is released, it should fix itself for installing the qa additions/

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Nov 6, 2024

@arrowtype in a fresh py3.13 venv try pip install git+https://github.com/googlefonts/[email protected]. Support for QA additions in 3.13 are a fortnight or so away.

@arrowtype
Copy link
Contributor

Success! That works perfectly for the person who was having issues with pyGit2. Installed in a venv, then used gftools --version and saw the specific version, plus (I think) a git commit hash.

Thanks!

@m4rc1e m4rc1e merged commit a64af18 into main Nov 14, 2024
10 of 11 checks passed
@vv-monsalve
Copy link
Contributor

Thanks, @m4rc1e!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygit2 installation blocker: "fatal error: 'git2.h' file not found"
3 participants