Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error when an unknown fontmake filter is provided to fontc #1089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hoolean
Copy link
Contributor

@Hoolean Hoolean commented Mar 8, 2025

My understanding is that this was the original intention of the code, but that the fall-through case performs the task of skipping too. (cc @cmyr would benefit from your know-how here, is this indeed what we want to support? 🔎 )

Merging would lead to additional fails on crater, but in at least some cases (e.g. the Jersey family) for families that have a low % match already owing to an unsupported filter; this would become more explicit.

Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction

My understanding is that this was the original intention of the code,
but that the fallthrough case performed the task of skipping too.

Merging would lead to additional fails on crater, but in at least some
cases (e.g. the Jersey family) for families that have a low % match
already owing to an unsupported filter; this would become more explicit.
@simoncozens simoncozens requested a review from cmyr March 8, 2025 21:08
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was I misunderstanding the semantics of pass? The intention was that we would raise an error when we saw an unknown filter, so that we could explicitly decide how we wanted to hande them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants