Raise an error when an unknown fontmake filter is provided to fontc #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that this was the original intention of the code, but that the fall-through case performs the task of skipping too. (cc @cmyr would benefit from your know-how here, is this indeed what we want to support? 🔎 )
Merging would lead to additional fails on crater, but in at least some cases (e.g. the Jersey family) for families that have a low % match already owing to an unsupported filter; this would become more explicit.
Note: this is a personal contribution independent of my employer, and so I've submitted from a fork under my personal profile and email to make this distinction