Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gftools packager: refactor #848

Merged
merged 22 commits into from
Mar 12, 2024
Merged

gftools packager: refactor #848

merged 22 commits into from
Mar 12, 2024

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Mar 8, 2024

Following PR refactors the packager to meet the following criteria:

  • Drop upstream.yaml files since metadata files now have all the necessary source fields
  • Simplify the commands based on feedback received from users
  • Aggressively simplify. Users weren't too fussed by interactive mode so this has been dropped
  • Add a batch packager so we can update all families in the collection
  • Simplify code. Codebase is now a quarter of the size and far easier to understand
  • Add onboarder checklist to pull request messages
  • Don't onboard families that lack family categorisation tags.

@simoncozens
Copy link
Contributor

Somehow this rewrote my repository_url to https://wwwhub.com/.......

@simoncozens
Copy link
Contributor

Hahaha!

    metadata.source.repository_url = metadata.source.repository_url.replace(".git", "")

@m4rc1e m4rc1e marked this pull request as ready for review March 12, 2024 14:53
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Mar 12, 2024

@simoncozens I'm very happy with your new commits. Happy to merge if you're happy?

@simoncozens
Copy link
Contributor

Yes, LGTM.

@m4rc1e m4rc1e force-pushed the packager2 branch 4 times, most recently from 703d788 to 4d44355 Compare March 12, 2024 16:07
@m4rc1e m4rc1e merged commit 4cb2db8 into main Mar 12, 2024
11 checks passed
@simoncozens simoncozens deleted the packager2 branch May 30, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants