Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to PR checklist #991

Closed
wants to merge 1 commit into from
Closed

Conversation

yanone
Copy link
Contributor

@yanone yanone commented Jun 17, 2024

Since many steps in creating a PR are now automated (labels, issue linking), one might simply forget to add the PR to the traffic jam project board where they will be discovered for review.

@yanone yanone requested a review from m4rc1e June 17, 2024 15:03
@yanone
Copy link
Contributor Author

yanone commented Jun 17, 2024

@m4rc1e:

The Traffic Jam link failed with:

                     [ { 'locations': [{'column': 5, 'line': 3}],                                                   
                        'message': 'Your token has not been granted the required scopes to execute '                
                                   "this query. The 'addProjectV2ItemById' field requires one of "                  
                                   "the following scopes: ['project'], but your token has only "                    
                                   "been granted the: ['admin:enterprise', 'admin:gpg_key', "                       
                                   "'admin:org', 'admin:org_hook', 'admin:public_key', "                            
                                   "'admin:repo_hook', 'delete:packages', 'delete_repo', 'gist', "                  
                                   "'notifications', 'repo', 'user', 'workflow', "                                  
                                   "'write:discussion', 'write:packages'] scopes. Please modify "                   
                                   "your token's scopes at: https://github.com/settings/tokens.",                   
                        'type': 'INSUFFICIENT_SCOPES'}

While I appreciate the effort on your end to implement my request, after seeing the user experience of having to add the file manually (even if it worked), I now tend to think we should discard this conduct and just make sure by reminding people (and adding a check to the list) that onboarders add the PR manually.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 27, 2024

@yanone in https://github.com/settings/tokens, add the following to your PAT:

Screenshot 2024-06-27 at 10 11 19

@yanone
Copy link
Contributor Author

yanone commented Jun 27, 2024

Thank you, that worked

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 27, 2024

I'm going to close this. Tbh, the checklist is starting to feel too long and I think people are ignoring it.

@m4rc1e m4rc1e closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants