Skip to content

kadai2-micchie #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

kadai2-micchie #17

wants to merge 8 commits into from

Conversation

mi-bear
Copy link
Member

@mi-bear mi-bear commented Jul 30, 2019

Overview

  • io.Reader と io.Writer が標準パッケージでどのように使われているか (README.md)
  • io.Reader と io.Writer があることでどういう利点があるのか具体例を挙げて考えてみる (README.md)
  • テストのしやすさを考えてリファクタリングしてみる
  • テストのカバレッジを取ってみる
  • テーブル駆動テストを行う
  • テストヘルパーを作ってみる

Command

  -after string
    	image format after conversion (default "png")
  -before string
    	image format before conversion (default "jpg")
  -d string
    	path of images to convert [required]

Cover

kadai2-cover

分からないところ:

  • filepath.Walk の部分はどんな風にテストを書けば良いのか。
  • err のテストの分離。
  • テストヘルパーはどんなときに使うと良いものなのか。

@mi-bear mi-bear added the kadai2 label Jul 30, 2019
@mi-bear mi-bear requested a review from tenntenn July 30, 2019 06:05
@mi-bear mi-bear self-assigned this Jul 30, 2019
@mi-bear
Copy link
Member Author

mi-bear commented Jul 31, 2019

TODO:

  • ヘルパーを書く
  • t.Parallel() を入れる
  • テストパッケージにする
  • サブテストを使う
  • interface{} の使い所がありそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant