kadai3-1-micchie #24
Open
kadai3-1-micchie #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Aug 7, 2019
|
|
||
| // Game はtタイピングゲームのコンテキストや入出力などの情報を格納します. | ||
| type Game struct { | ||
| Context context.Context |
| scan <- scanner.Text() | ||
| } | ||
| if err := scanner.Err(); err != nil { | ||
| fmt.Fprintln(os.Stderr, "input:", err) |
|
|
||
| switch { | ||
| case g.Score.Count == len(g.Words): | ||
| fmt.Fprintln(g.Output, fmt.Sprintf( |
| ) | ||
|
|
||
| func TestGame_Run(t *testing.T) { | ||
| g := &game.Game{} |
There was a problem hiding this comment.
これで良さそう
g := &game.Game{
TimeLimit: 5 * time.Second,
Words: []string{
// 略
},
}| "bear", | ||
| } | ||
|
|
||
| ch := make(chan string) |
| time.Sleep(2 * time.Second) | ||
| ch <- "beer" | ||
| }() | ||
|
|
|
|
||
| // Config is a structure of config.yml. | ||
| var Config = struct { | ||
| Limit time.Duration `default:"30"` |
There was a problem hiding this comment.
time.Duration型はすでに時間単位を型情報として持っているので、30は30秒という意味にはできない。
time.Duration型で30は30ナノ秒を表す。
https://golang.org/pkg/time/#pkg-constants
| } | ||
|
|
||
| func shuffle(list []string) { | ||
| rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
乱数の種の設定はプログラムで1回やれば十分。
通常は関数呼び出しごとにはやらずに、初期化だけ行う。
| g.Run() | ||
| } | ||
|
|
||
| func shuffle(list []string) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Command
Description
config.yml に制限時間と, 出力する英単語を登録して実行をします。
つぶやき