Kadai3-1 yashiken #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tenntenn
reviewed
Aug 7, 2019
| @@ -0,0 +1,23 @@ | |||
| # 課題1 回答 | |||
tenntenn
reviewed
Aug 7, 2019
| "github.com/gopherdojo/dojo6/kadai3-1/yashiken/typegame" | ||
| ) | ||
|
|
||
| var t int |
There was a problem hiding this comment.
パッケージ変数は短くしない。
1文字にするのはブロックスコープの変数（引数やレシーバも含む）とunexportedなフィールドくらい。
tenntenn
reviewed
Aug 7, 2019
| func main() { | ||
| var ( | ||
| tm = time.After(time.Duration(t) * time.Minute) | ||
| score = 0 |
tenntenn
reviewed
Aug 7, 2019
| // 単語リストの取得 | ||
| words, err := typegame.Words(s) | ||
| if err != nil { | ||
| fmt.Println(err) |
tenntenn
reviewed
Aug 7, 2019
| // 単語リストの要素をランダムに入れ替え | ||
| words = typegame.Shuffle(words) | ||
|
|
||
| fmt.Printf("タイピングゲームを始めます。制限時間は%d分です。\n", t) |
tenntenn
reviewed
Aug 7, 2019
| words = typegame.Shuffle(words) | ||
|
|
||
| fmt.Printf("タイピングゲームを始めます。制限時間は%d分です。\n", t) | ||
| for i := true; i && score < len(words); { |
There was a problem hiding this comment.
iは通常添字（int型の）に使うのでbool型の値に使わない。
フラグを使わずにbreakすればよい。
tenntenn
reviewed
Aug 7, 2019
| // 標準入力の内容を受け取ったあとチャネルに格納して返します。 | ||
| func Input(r io.Reader) <-chan string { | ||
| ch := make(chan string) | ||
| go func() { |
tenntenn
reviewed
Aug 7, 2019
| // shuffleはスライスの要素をランダムに入れ替え、 | ||
| // 要素を入れ替えたスライスを返します。 | ||
| func Shuffle(s []string) []string { | ||
| rand.Seed(time.Now().UnixNano()) |
tenntenn
reviewed
Aug 7, 2019
|
|
||
| // shuffleはスライスの要素をランダムに入れ替え、 | ||
| // 要素を入れ替えたスライスを返します。 | ||
| func Shuffle(s []string) []string { |
tenntenn
reviewed
Aug 7, 2019
| input string | ||
| output string | ||
| }{ | ||
| { |
tenntenn
reviewed
Aug 7, 2019
| }) | ||
| } | ||
| } | ||
| func TestShuffle(t *testing.T) { |
There was a problem hiding this comment.
これはテストの必要性があるのか？rand.Perm使えば別にこの関数ごといらなさそう。
tenntenn
reviewed
Aug 7, 2019
| success bool | ||
| ) | ||
| // ランダムにスライスの要素を入れ替えるため、十分な回数shuffleを実行 | ||
| for i := 1; i < 1000; i++ { |
tenntenn
reviewed
Aug 7, 2019
| ) | ||
| // ランダムにスライスの要素を入れ替えるため、十分な回数shuffleを実行 | ||
| for i := 1; i < 1000; i++ { | ||
| if result = typegame.Shuffle(c.input); reflect.DeepEqual(result, c.output) { |
tenntenn
reviewed
Aug 7, 2019
| t.Run(c.name, func(t *testing.T) { | ||
| path := filepath.Join("testdata/" + c.file) | ||
| sl, err := typegame.Words(path) | ||
| if !reflect.DeepEqual(sl, c.output) && err != c.expectErr { |
There was a problem hiding this comment.
slとc.outputの比較とエラーの比較がなぜ&&で繋げられてるんでしょうか？
エラーは値で比較しない。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題3−1
タイピングゲームをつくる
TODO
Usage
感想