Skip to content

xgo: v1.7.2#463

Merged
visualfc merged 1 commit into
goplus:mainfrom
visualfc:xgo
Jun 8, 2026
Merged

xgo: v1.7.2#463
visualfc merged 1 commit into
goplus:mainfrom
visualfc:xgo

Conversation

@visualfc

@visualfc visualfc commented Jun 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Go dependencies in go.mod and go.sum, including github.com/goplus/gogen, github.com/goplus/xgo, golang.org/x/mod, golang.org/x/tools, and golang.org/x/sync. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR promotes pseudo-versions to proper tagged releases and bumps standard library tooling dependencies. The changes are mechanically correct and represent good module hygiene.

Summary of changes:

  • goplus/xgo: pseudo-version → v1.7.2 (stable release) ✓
  • goplus/gogen: pseudo-version → v1.23.0-pre.5 (pre-release, but intentional — xgo v1.7.2 requires this version)
  • golang.org/x/mod: v0.29.0v0.32.0
  • golang.org/x/tools: v0.38.0v0.41.0
  • golang.org/x/sync removed from direct require block: correct, as ixgo does not import it directly; it remains transitively present in go.sum at v0.19.0
  • go.sum is correctly updated for all version changes

Note: github.com/goplus/gogen remains on a pre-release tag (v1.23.0-pre.5). This is an accepted constraint driven by xgo v1.7.2's own dependency requirements and is not a concern specific to this PR — downstream consumers of ixgo will transitively depend on pre-release gogen until a stable v1.23.0 is tagged.

No security, performance, or correctness issues found.

@visualfc visualfc merged commit d4c31c7 into goplus:main Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant