Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy nested directories when using app.Publishes #386

Closed
wants to merge 2 commits into from

Conversation

rohitkeshwani07
Copy link

@rohitkeshwani07 rohitkeshwani07 commented Jan 3, 2024

Closes # Issue 345

πŸ“‘ Description

This will support copy of nested directories when needed with app.Publishes() as used by goravel/gateway here

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@hwbrzzl hwbrzzl changed the title copy nested directories when using app.Publishes fix: copy nested directories when using app.Publishes Jan 4, 2024
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and surprised you are using goravel/gateway, it hasn't been published. Please optimize the unit tests, the CI failed. A good PR. πŸ‘

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (aa22c1c) 69.26% compared to head (a396120) 69.21%.
Report is 1 commits behind head on master.

Files Patch % Lines
foundation/console/vendor_publish_command.go 64.28% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   69.26%   69.21%   -0.06%     
==========================================
  Files         152      152              
  Lines       10922    10949      +27     
==========================================
+ Hits         7565     7578      +13     
- Misses       2849     2859      +10     
- Partials      508      512       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Jan 6, 2024

Could you please add unit tests for your new logic? And create your PR based on the v1.13.x branch, we can merge this PR to v1.13.x, and release v1.13.8. Thanks so much.

@hwbrzzl hwbrzzl closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants