Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build command #422

Merged
merged 13 commits into from
Feb 26, 2024
Merged

feat: add build command #422

merged 13 commits into from
Feb 26, 2024

Conversation

Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Feb 16, 2024 •
edited
Loading

Closes #359

📑 Description

add build command

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@Kamandlou Kamandlou changed the title add build command feat: add build command Feb 16, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.33333% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 71.10%. Comparing base (335621c) to head (3c2ab57).

Files Patch % Lines
console/console/build_command.go 64.40% 19 Missing and 2 partials ⚠️
console/service_provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   71.15%   71.10%   -0.05%     
==========================================
  Files         162      163       +1     
  Lines        9849     9909      +60     
==========================================
+ Hits         7008     7046      +38     
- Misses       2287     2307      +20     
- Partials      554      556       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kamandlou
Copy link
Contributor Author

Hi @hwbrzzl,
This PR is Review Ready.

hwbrzzl
hwbrzzl reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beautiful PR. 👍

@Kamandlou Kamandlou requested a review from hwbrzzl February 16, 2024 16:26
@Kamandlou
Copy link
Contributor Author

@hwbrzzl

hwbrzzl
hwbrzzl reviewed Feb 17, 2024
View reviewed changes
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Feb 24, 2024

CI failed

hwbrzzl
hwbrzzl approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@hwbrzzl hwbrzzl merged commit 8862fa5 into goravel:master Feb 26, 2024
8 of 10 checks passed
@Kamandlou Kamandlou deleted the buildCommand branch February 27, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Create a new command to simplify build process
2 participants
@Kamandlou @hwbrzzl