fix: race condition in both upsert post and upsert patch

[luthfifahlevi]

When some jobs that has same recipe run at the same time, it makes those assets has the version in assets_versions table greater than version in assets table. This is not expected because version in assets table should be the (new) highest number, so should be equals to highest number of the version in assets_versions . The expectation is with transaction sql (the race condition should be handled), it will insert new rows in assets_version with increasing minor version (exp: 0.9 → 0.10) IF ONLY there is an update on the job AND has the changelog.

For example bug case:

• asset_test_a in assets table has version 0.99
• The highest version for asset_test_a in assets_versions table has version 0.100
• When update the assets and has change log, it will raise error duplicate key value violates unique constraint "assets_versions_idx_asset_id_version" since combination asset_test_a ID and 0.100 already exist

The solution:
Using Row-level Locks (ref: https://www.postgresql.org/docs/current/explicit-locking.html#LOCKING-ROWS) with SELECT FOR UPDATE within same transaction for update

[coveralls]

Pull Request Test Coverage Report for Build 13215384412

Details

• 53 of 71 (74.65%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.03%) to 83.983%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/store/postgres/asset_repository.go	53	71	74.65%

Files with Coverage Reduction	New Missed Lines	%
internal/store/postgres/asset_repository.go	1	78.03%

Totals
Change from base Build 12114630025:	-0.03%
Covered Lines:	6890
Relevant Lines:	8204

---

💛 - Coveralls

[batrov]

is there any case where the assetID changed?

[luthfifahlevi]

should be not. Its UUID anyway, so ideally we use URN instead for Upsert identifier

And actually assetID came from fetchedAsset

compass/internal/store/postgres/asset_repository.go

Line 341 in 7acbcda

err = r.update(ctx, fetchedAsset.ID, ast, &fetchedAsset, changelog)

which is it got from existing asset (old asset) by GetByURN, so I just refactor it to remove redundancy

[mabdh]

we can remove this function if not needed

[luthfifahlevi]

still used in GetAssetByID API here:

compass/core/asset/service.go

Line 213 in 7acbcda

ast, err = s.assetRepository.GetByID(ctx, id)