chore: add Add Elements tool to dataset sdk #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
changed the title
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Oct 22, 2024
| @@ -39,7 +35,7 @@ func (r datasetRequest) getToolRepo() string { | |||
| if r.DatasetToolRepo != "" { | |||
| return r.DatasetToolRepo | |||
| } | |||
| return "github.com/gptscript-ai/datasets" | |||
| return "github.com/otto8-ai/datasets" | |||
There was a problem hiding this comment.
I am going to move the datasets repo as soon as my PR there is merged.
g-linville
commented
Oct 22, 2024
| @@ -73,6 +73,7 @@ func (s *server) addRoutes(mux *http.ServeMux) { | |||
| mux.HandleFunc("POST /datasets/list-elements", s.listDatasetElements) | |||
| mux.HandleFunc("POST /datasets/get-element", s.getDatasetElement) | |||
| mux.HandleFunc("POST /datasets/add-element", s.addDatasetElement) | |||
| mux.HandleFunc("POST /datasets/add-elements", s.addDatasetElements) | |||
There was a problem hiding this comment.
This is a new route for the Add Elements tool.
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42,
tylerslaton and
drpebcak
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gptscript-ai/datasets#4
This updates the SDKServer to better handle the new changes to the dataset tools.