fix: credentials: check for not found errors properly #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
njhale
approved these changes
Nov 6, 2024
thedadams
approved these changes
Nov 6, 2024
StrongMonkey
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring of credential helpers to be run as tools resulted in a bug where the output of the credential tool (which would become part of the error message) would have things appended to it like
:\n exit status 1, which was messing up the detection of Not Found errors. I fixed this in this PR by implementing our own function to examine the error message. I wish I could have used the definedconstfor this from the Docker package that we depend on, but it is unexported.