enhance: add a maximum consecutive tools calls restriction #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
thedadams
force-pushed
the
max-consecutive-tool-calls
branch
from
e2979f4 to
955bc9c
Compare
This is a safety net for instances when the LLM goes awry. There is an undocumented environment variable to change the maximum number of consecutive tool calls from the default of 10. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
max-consecutive-tool-calls
branch
from
955bc9c to
2dedf54
Compare
g-linville
approved these changes
Jan 3, 2025
njhale
approved these changes
Jan 3, 2025
| // Limit the number of consecutive tool calls and responses. | ||
| // We don't want the LLM to call tools unrestricted or get stuck in an error loop. | ||
| var messagesSinceLastUserMessage int | ||
| for _, msg := range slices.Backward(state.Completion.Messages) { |
There was a problem hiding this comment.
Using the new iterator functions, nice! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a safety net for instances when the LLM goes awry. There is an undocumented environment variable to change the maximum number of consecutive tool calls from the default of 10.
Issue: obot-platform/obot#940