Skip to content

fix: estimate tokens using tiktoken #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

g-linville
Copy link
Member

@g-linville g-linville commented Apr 9, 2025

@g-linville g-linville force-pushed the fix-token-estimation branch from d913ca7 to fd36b2c Compare April 10, 2025 02:54
@g-linville g-linville changed the title WIP fix: estimate tokens using tiktoken Apr 10, 2025
@g-linville g-linville marked this pull request as ready for review April 10, 2025 03:04
njhale
njhale previously approved these changes Apr 10, 2025
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, but otherwise lgtm

Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville merged commit c519c63 into gptscript-ai:main Apr 10, 2025
10 checks passed
@g-linville g-linville deleted the fix-token-estimation branch April 10, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants