chore: switch to huma for OpenAPI v3.1 support #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
commented
May 20, 2025
| @@ -373,6 +373,147 @@ func parseServer(server *openapi3.Server) (string, error) { | |||
| return s, nil | |||
| } | |||
|
|
|||
| // openAPI3SchemaToHumaV2Schema converts an openapi3.Schema to a humav2.Schema | |||
| func openAPI3SchemaToHumaV2Schema(schema *openapi3.Schema) *humav2.Schema { | |||
There was a problem hiding this comment.
Junie did this for me. I checked it out and it seems good, but would appreciate some eyes on this.
thedadams
force-pushed
the
openapi-v3.1-support
branch
from
fa31e6c to
b77836f
Compare
thedadams
commented
May 20, 2025
Comment on lines
+400
to
+419
| if schema.Min != nil { | ||
| minVal := *schema.Min | ||
| result.Minimum = &minVal | ||
|
|
||
| // In OpenAPI 3, ExclusiveMin is a boolean flag that applies to Min | ||
| // In OpenAPI 3.1, ExclusiveMinimum is a separate value | ||
| if schema.ExclusiveMin { | ||
| result.ExclusiveMinimum = &minVal | ||
| } | ||
| } | ||
| if schema.Max != nil { | ||
| maxVal := *schema.Max | ||
| result.Maximum = &maxVal | ||
|
|
||
| // In OpenAPI 3, ExclusiveMax is a boolean flag that applies to Max | ||
| // In OpenAPI 3.1, ExclusiveMaximum is a separate value | ||
| if schema.ExclusiveMax { | ||
| result.ExclusiveMaximum = &maxVal | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the real reason we needed to switch.
Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
openapi-v3.1-support
branch
from
b77836f to
65c3ec2
Compare
g-linville
approved these changes
May 20, 2025
njhale
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.