Skip to content

fix: track and process fragmented stdout stream #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedadams merged 1 commit into from
May 8, 2024
Merged

fix: track and process fragmented stdout stream #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/gptscript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,9 @@ export class Run {
this.state = RunState.Running

if (this.process.stdout) {
let frag = ""
this.process.stdout.on("data", (data: any) => {
this.processStdout(data.toString())
frag = this.processStdout(frag + data.toString())
})
}

Expand Down Expand Up @@ -339,17 +340,16 @@ export class Run {
})
}

processStdout(data: string | object): void {
processStdout(data: string | object): string {
if (typeof data === "string") {
if (data.trim() === "") {
return
return ""
}

try {
data = JSON.parse(data)
} catch (e) {
this.err = `Failed to parse stdout: "${data}"`
return
return data as string
}
}

Expand All @@ -361,6 +361,8 @@ export class Run {
this.state = RunState.Finished
this.chatState = undefined
}

return ""
}

request(tool: any) {
Expand Down Expand Up @@ -655,12 +657,14 @@ class RunSubcommand extends Run {
super(subCommand, path, content, opts, bin, gptscriptURL)
}

processStdout(data: string | object) {
processStdout(data: string | object): string {
if (typeof data === "string") {
this.stdout = (this.stdout || "") + data
} else {
this.stdout = JSON.stringify(data)
}

return ""
}
}

Expand Down