Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert back to CJS and use ncc. #139

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Convert back to CJS and use ncc. #139

merged 3 commits into from
Feb 12, 2025

Conversation

fniephaus
Copy link
Member

This PR reverts #134 due to a subtle issue with minimatch and require and converts back to CJS and use ncc. It also ensures that the maven cache feature is tested.

Fixes #137 and fixes #138.

@fniephaus fniephaus requested a review from eregon February 12, 2025 20:05
@fniephaus fniephaus self-assigned this Feb 12, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 12, 2025
Copy link

GraalVM Native Image Build Report

helloworld generated in 49.6s as part of the 'test-action-native-image-musl' job in run #68.

Environment

Java version 25+8 Vendor version GraalVM CE 25-dev+8.1
Graal compiler optimization level: 2, target machine: x86-64-v3
C compiler x86_64-linux-musl-gcc (linux, x86_64, 10.2.1)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 3,170 68.674% 3,588 41.175% 14,687 42.365%
Reflection 1,009 21.859% 8 0.092% 118 0.340%
JNI 57 1.235% 58 0.666% 52 0.150%
Loaded 4,616 100.000% 8,714 100.000% 34,668 100.000%

Image Details

Category Size in % Details
Code area 4.93MB 37.897% 8,418 compilation units
Image heap 6.69MB 51.382% 85,180 objects, 171.41KB for 55 resources
Other data 1.40MB 10.721%
Total 13.02MB 100.000%

Resource Usage

Garbage collection 2.14s (4.316% of total time) in 509 GCs
Peak RSS 1.06GB (6.786% of 15.62GB system memory)
CPU load 3.647 (91.178% of 4 CPU cores)

Report generated by setup-graalvm.

Copy link

GraalVM Native Image Build Report

helloworld generated in 56.4s as part of the 'test-action-native-image-windows-msvc' job in run #68.

Environment

Java version 17.0.12+8-LTS Vendor version Oracle GraalVM 17.0.12+8.1
Graal compiler optimization level: 2, target machine: x86-64-v3, PGO: ML-inferred
C compiler cl.exe (microsoft, x64, 19.42.34436)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 1,809 59.311% 1,684 45.587% 7,635 35.793%
Reflection 618 20.262% 0 0.000% 282 1.322%
JNI 53 1.738% 30 0.812% 48 0.225%
Loaded 3,050 100.000% 3,694 100.000% 21,331 100.000%

Image Details

Category Size in % Details
Code area 2.77MB 43.921% 3,464 compilation units
Image heap 3.45MB 54.709% 48,657 objects, 108.00B for 1 resources
Other data 88.45KB 1.370%
Total 6.30MB 100.000%

Resource Usage

Garbage collection 1.73s (3.063% of total time) in 129 GCs
Peak RSS 958.22MB (5.849% of 16.00GB system memory)
CPU load 3.137 (78.418% of 4 CPU cores)

Report generated by setup-graalvm.

Copy link

GraalVM Native Image Build Report

helloworld.exe generated in 1m 25s as part of the 'test-action-native-image-windows' job in run #68.

Environment

Java version 25+8 Vendor version GraalVM CE 25-dev+8.1
Graal compiler optimization level: 2, target machine: x86-64-v3
C compiler cl.exe (microsoft, x64, 19.42.34436)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 3,149 69.361% 3,586 41.328% 14,674 42.450%
Reflection 996 21.938% 8 0.092% 118 0.341%
JNI 61 1.344% 51 0.588% 52 0.150%
Loaded 4,540 100.000% 8,677 100.000% 34,568 100.000%

Image Details

Category Size in % Details
Code area 5.10MB 41.875% 8,441 compilation units
Image heap 6.69MB 54.889% 85,015 objects, 171.41KB for 55 resources
Other data 403.64KB 3.235%
Total 12.18MB 100.000%

Resource Usage

Garbage collection 2.40s (2.794% of total time) in 497 GCs
Peak RSS 1.05GB (6.583% of 16.00GB system memory)
CPU load 2.321 (58.021% of 4 CPU cores)

Report generated by setup-graalvm.

Copy link

GraalVM Native Image Build Report

helloworld generated in 47.8s as part of the 'test-action-extensive' job in run #68.

Environment

Java version 17.0.8+9-LTS Vendor version Oracle GraalVM 17.0.8+9.1
Graal compiler optimization level: 2, target machine: x86-64-v3, PGO: ML-inferred
C compiler gcc (linux, x86_64, 13.3.0)
Garbage collector Serial GC

Analysis Results

Category Types in % Fields in % Methods in %
Reachable 1,853 59.145% 1,737 46.369% 7,712 35.616%
Reflection 638 20.364% 0 0.000% 281 1.298%
JNI 49 1.564% 32 0.854% 48 0.222%
Loaded 3,133 100.000% 3,746 100.000% 21,653 100.000%

Image Details

Category Size in % Details
Code area 2.75MB 23.182% 3,484 compilation units
Image heap 3.46MB 29.165% 48,946 objects, 108.00B for 1 resources
Debug info 5.33MB 44.903%
Other data 334.46KB 2.749%
Total 11.88MB 100.000%

Resource Usage

Garbage collection 1.84s (3.857% of total time) in 270 GCs
Peak RSS 925.51MB (5.788% of 15.62GB system memory)
CPU load 3.591 (89.768% of 4 CPU cores)

Report generated by setup-graalvm.

@fniephaus fniephaus merged commit b0cb26a into main Feb 12, 2025
226 checks passed
@fniephaus fniephaus deleted the fniephaus/cjs-ncc branch February 12, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub action does not work on Windows 1.3.0 seems to fail on windows-latest
2 participants