fix(Faro): Exception context got lost while transforming Faro exceptions. #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlankfo
approved these changes
Aug 1, 2024
codecapitano
added
bug
|
Hope I got the backport tags right. |
…orming-faro-exceptions
tpaschalis
deleted the
fix--exception-context-got-lost-while-trasnforming-faro-exceptions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
We got reports from Faro users that user provided exception context was somehow lost when using Alloy.
This was because the context object returned by the
transformExceptionfunction was missing the context.Which issue(s) this PR fixes
pushError loses context data
Notes to the Reviewer
PR Checklist