Default to 0.0.0.0 instead of localhost in OTel receivers
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gRPC servers. This rollbacks a recent OTel breaking change.
wildum
approved these changes
Aug 2, 2024
wildum
pushed a commit
that referenced
this pull request
Aug 2, 2024
… gRPC servers. (#1414) This rollbacks a recent OTel breaking change.
wildum
added a commit
that referenced
this pull request
Aug 2, 2024
… gRPC servers. (#1414) (#1415) This rollbacks a recent OTel breaking change. Co-authored-by: Paulin Todev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This rollbacks a recent OTel breaking change, which was ported to Alloy in #1362 but so far it hasn't been released in Alloy officially (it's just been on the main branch for a few days).
The initial argument for having the breaking change in Alloy was that it gives users a more up to date OTel experience, which aligns with the upstream defaults. However, this particular breaking change has such a large impact that we decided the best time to introduce it would be in Alloy 2.0, which will probably go out at some point next year.
Notes to the Reviewer
The converters will now explicitly convert
endpointattributes tolocalhost, sincelocalhostis what upstream uses by default.PR Checklist