remotecfg: fix logic around skipping loaded configuration #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
tpaschalis
requested review from
erikbaranowski,
spartan0x117,
captncraig and
johannaojeling
| @@ -480,22 +479,21 @@ func (s *Service) parseAndLoad(b []byte) error { | |||
| if len(b) == 0 { | |||
| return nil | |||
| } | |||
|
|
|||
| s.setLastLoadedCfgHash(getHash(b)) | |||
There was a problem hiding this comment.
is it possible to get a length 0 config and get stuck doing:
good config -> 0 length config -> good config
There was a problem hiding this comment.
answered myself: we will never set the 0 length config into the hash OR attempt to load it. looks good!
erikbaranowski
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR:
currentConfigHashtolastLoadedConfigHash.parseAndLoad, before we attempt to pass it the configuration to the controller, and nowhere elseThe other thing to do would be to remove this logic entirely and only depend on the server's response as to whether we should skip applying configurations or not.
Given this is likely a breaking change, this is our chance to choose what to do here before removing the
private-previewlabel from the next release. Thoughts?Which issue(s) this PR fixes
No issue filed.
Notes to the Reviewer
PR Checklist