feat(loki.source.file): Track duplicate targets with a metric and logs #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview available (feat(loki.source.file): Track duplicate targets with a metric and logs): |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
It's possible to send
loki.source.filethe same file target multiple times. This PR adds logs and a metric to help us identify whether this has happened. It is currently very hard to debug this - you'd have to open the Alloy UI and check thetargetspassed toloki.source.fileto see if any file paths have been listed multiple times with differing non-internal labels (labels which don't start with__).A common way to encounter this problem is if you pair
loki.source.filewithdiscovery.kubernetesand then make a label with a pod port number prior toloki.source.file. If the pod has multiple ports, you'd end up tailing the file twice.Issue(s) fixed by this Pull Request
Related to this comment.
PR Checklist