-
Notifications
You must be signed in to change notification settings - Fork 516
perf(loki.write): Pre-allocate buffers used for batch encoding #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kalleep
wants to merge
13
commits into
main
Choose a base branch
from
kalleep/fix-loki-batch-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+395
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now respect the actualy request size, before compression. Also enfoce size check when adding to a batch instead of seperate function
kalleep
commented
Feb 9, 2026
kalleep
commented
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
By pre-allocating buffers for requests we can reduce total amount of memory allocated by
loki.writePull Request Details
Before this change we allocated two buffers every time we encoded a batch:
push.PushRequestBecause a shard will only ever send one batch at a time we can allocate two buffers that we re-suse for each request. My first attempt to fix this was to fix the size check in a batch. We only check size of line and size of structured metadata when appending to a batch.
Ideally we should count the serialized bytes it would take to add an entry to a batch and labels. I made two attempts to do this. They where both correct but it consumed a lot of CPU to do this. If this had worked out we could always pre-allocate these two buffers and always re-used them and
batch_sizewould actually be respected. Currently we always go over the configured value a lot.Because it's really expensive to keep a correct count I reverted back to the old behavior and changed the API a bit. We now call
requeston batch to get the request we have built and number of entries it contains. We then adjust the buffers after the largest batch we have seen and reuse them.Issue(s) fixed by this Pull Request
Notes to the Reviewer
I did some other changes to batch:
additself and handle errors at call sites instead.PR Checklist