Skip to content

Conversation

@armsnyder
Copy link

@armsnyder armsnyder commented Feb 9, 2026

Brief description of Pull Request

Updates otelcol.processor.resourcedetection component config to add new config params supported by the upstream opentelemetry-collector-contrib, as well as fix a bug where the eks detector was fully broken, because it was not passing a value to the node_from_env_var upstream field.

Pull Request Details

  • Adds gcp.labels
  • Adds eks.node_from_env_var
  • Updates the otelcol.processor.resourcedetection documentation.
    • Removed the akamai.fail_on_missing_metadata attribute from the documentation, since it has no effect.
    • Removed the dynatrace attributes from the documentation, since they have no effect.
    • (No Alloy config fields were removed in this PR, so it is not breaking.)

Issue(s) fixed by this Pull Request

Related to #5481. This is one half of the fix.

Notes to the Reviewer

I don't see how the eks detector would have been working without supporting the node_from_env_var field. I think this has been broken since Alloy 1.10.0, when the upstream version was updated without supporting this field.

  • Validated that Alloy now supports all config params in the latest opentelemetry-collector-contrib resourcedetection code.
  • Validated that the schema links all work (except for dynatrace, which does not have any config, but I am leaving the comment for future-proofing.)

PR Checklist

  • Documentation added
  • Config converters updated

@armsnyder armsnyder requested review from a team and clayton-cornell as code owners February 9, 2026 23:06
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2026

CLA assistant check
All committers have signed the CLA.

@armsnyder armsnyder force-pushed the 5481-otelcol-node-name branch from 70decda to 54de76b Compare February 9, 2026 23:08
CloudProvider: rac.ResourceAttributeConfig{Enabled: true},
K8sClusterName: rac.ResourceAttributeConfig{Enabled: false},
},
NodeFromEnvVar: "K8S_NODE_NAME",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the env var name used by the existing k8snode processor.

@armsnyder armsnyder changed the title feat: Add otelcol.processor.resourcedetection config for gcp labels and eks node name fix: Add otelcol.processor.resourcedetection config for gcp labels and eks node name Feb 9, 2026
@armsnyder armsnyder force-pushed the 5481-otelcol-node-name branch from 54de76b to 1f4613f Compare February 9, 2026 23:27
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Docs Squad label across all Grafana Labs repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants