fix: Add otelcol.processor.resourcedetection config for gcp labels and eks node name #5483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Updates
otelcol.processor.resourcedetectioncomponent config to add new config params supported by the upstream opentelemetry-collector-contrib, as well as fix a bug where theeksdetector was fully broken, because it was not passing a value to thenode_from_env_varupstream field.Pull Request Details
gcp.labelseks.node_from_env_varotelcol.processor.resourcedetectiondocumentation.akamai.fail_on_missing_metadataattribute from the documentation, since it has no effect.dynatraceattributes from the documentation, since they have no effect.Issue(s) fixed by this Pull Request
Related to #5481. This is one half of the fix.
Notes to the Reviewer
I don't see how the
eksdetector would have been working without supporting thenode_from_env_varfield. I think this has been broken since Alloy 1.10.0, when the upstream version was updated without supporting this field.PR Checklist