grafananet: fix FlushSize metric #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
route/grafananet.go
Outdated
| @@ -338,9 +340,9 @@ func (route *GrafanaNet) retryFlush(metrics []*schema.MetricData, buffer *bytes. | |||
| // re-instantiate body, since the previous .Do() attempt would have Read it all the way | |||
| req.Body = ioutil.NopCloser(bytes.NewReader(body)) | |||
| } | |||
| log.Debugf("GrafanaNet sent metrics in %s -msg size %d", dur, len(metrics)) | |||
| log.Debugf("GrafanaNet sent %d metrics in %s -msg size %d", len(metrics), dur, len(metrics)) | |||
There was a problem hiding this comment.
Aren't we printing the number of metrics twice in this message now?
Signed-off-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
grafananetrouter, the definition of theFlushSizemetrics says its unit is Bytes. But the router's code observes the actual number of metrics sent out, which is also tracked by theunit=Metric.direction=outcounter.This PR fixes the router to track the number of bytes sent out to the destination with the request. This behaviour looks aligned with other routers, e.g. see
KafkaMdm.