rename methods for translation from logs to faro payload

grafana · Dec 16, 2024 · 59def8d · 59def8d
1 parent afbc4e9
commit 59def8d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/pkg/translator/faro/logs_to_faro.go b/pkg/translator/faro/logs_to_faro.go
@@ -20,9 +20,9 @@ import (
 	"go.opentelemetry.io/collector/pdata/plog"
 )
 
-// TranslateLogsToFaroPayloads converts a Logs pipeline data into []*faro.Payload
-func TranslateLogsToFaroPayloads(ctx context.Context, ld plog.Logs) ([]*faroTypes.Payload, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "TranslateLogsToFaroPayloads")
+// TranslateFromLogs converts a Logs pipeline data into []*faro.Payload
+func TranslateFromLogs(ctx context.Context, ld plog.Logs) ([]*faroTypes.Payload, error) {
+	ctx, span := otel.Tracer("").Start(ctx, "TranslateFromLogs")
 	defer span.End()
 
 	metaMap := make(map[string]*faroTypes.Payload, 0)

diff --git a/pkg/translator/faro/logs_to_faro_test.go b/pkg/translator/faro/logs_to_faro_test.go
@@ -91,7 +91,7 @@ var multipleLogRecordsWithTheSameResource = func() plog.Logs {
 	return ld
 }
 
-func TestTranslateLogsToFaroPayload(t *testing.T) {
+func TestTranslateFromLogs(t *testing.T) {
 	testcases := []struct {
 		name         string
 		ld           plog.Logs
@@ -171,7 +171,7 @@ func TestTranslateLogsToFaroPayload(t *testing.T) {
 
 	for _, tt := range testcases {
 		t.Run(tt.name, func(t *testing.T) {
-			faroPayloads, err := TranslateLogsToFaroPayloads(context.TODO(), tt.ld)
+			faroPayloads, err := TranslateFromLogs(context.TODO(), tt.ld)
 			tt.wantErr(t, err)
 			assert.ElementsMatch(t, tt.wantPayloads, faroPayloads)
 		})

diff --git a/pkg/translator/faro/traces_to_faro.go b/pkg/translator/faro/traces_to_faro.go
@@ -13,8 +13,9 @@ import (
 	semconv "go.opentelemetry.io/otel/semconv/v1.21.0"
 )
 
-func TranslateTracesToFaroPayload(ctx context.Context, td ptrace.Traces) ([]*faroTypes.Payload, error) {
-	ctx, span := otel.Tracer("").Start(ctx, "TranslateTracesToFaroPayload")
+// TranslateFromTraces converts a Traces pipeline data into []*faro.Payload
+func TranslateFromTraces(ctx context.Context, td ptrace.Traces) ([]*faroTypes.Payload, error) {
+	ctx, span := otel.Tracer("").Start(ctx, "TranslateFromTraces")
 	defer span.End()
 
 	resourceSpans := td.ResourceSpans()

diff --git a/pkg/translator/faro/traces_to_faro_test.go b/pkg/translator/faro/traces_to_faro_test.go
@@ -95,7 +95,7 @@ var generateTraceIDFromString = func(s string) ([16]byte, error) {
 	return traceID, nil
 }
 
-func TestTranslateTracesToFaroPayload(t *testing.T) {
+func TestTranslateFromTraces(t *testing.T) {
 	testcases := []struct {
 		name         string
 		td           ptrace.Traces
@@ -144,7 +144,7 @@ func TestTranslateTracesToFaroPayload(t *testing.T) {
 
 	for _, tt := range testcases {
 		t.Run(tt.name, func(t *testing.T) {
-			payloads, err := TranslateTracesToFaroPayload(context.TODO(), tt.td)
+			payloads, err := TranslateFromTraces(context.TODO(), tt.td)
 			tt.wantErr(t, err)
 			assert.ElementsMatch(t, tt.wantPayloads, payloads)
 		})