Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faro translator #25

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Faro translator #25

merged 8 commits into from
Dec 18, 2024

Conversation

mar4uk
Copy link
Collaborator

@mar4uk mar4uk commented Dec 11, 2024

Added package /pkg/translator/faro. This package contains OTLP -> Faro translation methods:

  • TranslateLogsToFaroPayloads
  • TranslateTeacesToFaroPayload
    Those methods will be used in faro exporter component. Will be done in the next PR

In the subsequent PR I will add Faro -> OTLP translation methods to use them in faro receiver component:

  • TranslateFaroPayloadToLogs
  • TranslateFaroPayloadToTraces

@mar4uk mar4uk requested review from t00mas and rlankfo December 11, 2024 16:16
Copy link
Member

@rlankfo rlankfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

I had a couple of minor questions but nothing that should block progress imo

@mar4uk mar4uk mentioned this pull request Dec 12, 2024
@mar4uk mar4uk merged commit 83ff049 into main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants