Faro receiver component #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlankfo
reviewed
Jan 29, 2025
pkg/receiver/faro/receiver.go
Outdated
Comment on lines
80
to
82
| resp.Header().Set("Access-Control-Allow-Origin", "*") | ||
| resp.Header().Set("Access-Control-Allow-Methods", "POST, OPTIONS") | ||
| resp.Header().Set("Access-Control-Allow-Headers", "Content-Type") |
There was a problem hiding this comment.
The confighttp.ServerConfig struct we embed has a CORS member we can configure. We shouldn't have to handle cors ourselves but we might want to add * in our default config because if left unset, cors will be disabled.
There was a problem hiding this comment.
Oh that's true - I'll fix this right away.
mar4uk
approved these changes
Feb 4, 2025
pkg/receiver/faro/encoder.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| pbContentType = "application/x-protobuf" |
There was a problem hiding this comment.
Was this variable used anywhere? couldn't find
There was a problem hiding this comment.
No, I think it's leftover from the draft, will remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.