fix(ring): use net.JoinHostPort to support IPv6 addresses #3903
+44
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks for fixing this!
May I ask you to fix one more occurrence in: https://github.com/grafana/pyroscope/blob/main/pkg/experiment/metastore/discovery/kuberesolver.go#L106
It's fine if not (as this is fix(ring)), we can do this later
|
In fact, I missed that. Just updated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Go's
net.JoinHostPortinstead of string formatting in ring lifecycler configuration to properly handle IPv6 addresses.Fixes #3900