Merged
Conversation
Collaborator
Author
|
I'm going to figure out why we allow such locations to get to the storage before merging. |
Contributor
|
I may have a repro for this issue (or some other issue)
cat 547df064-46df-465a-9ebc-6e7506bc9111.profile | curl -X POST --data-binary @- http://localhost:4040/ingest\?\name\=amixir\&format\=pprof 547df064-46df-465a-9ebc-6e7506bc9111.profile.zip
The results are different. The pprof comes from grafana/alloy#2920 I have not checked the pprof file itself, but it is likely mailformed or incorrect. I will take a look at the pprof sometime later next week. Eventhough pprof is mailformed it should not cause different query results or compaction issues, we still need to tackle this in the database. |
Collaborator
Author
|
Thanks for the sample! This is very weird, indeed – I'll take a careful look |
korniltsev
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


It's currently possible, that we ingest and store a profile with locations that refer to non-existent functions. This is causing panics at compaction, because we assume that such locations are sanitized at ingest time. If a profile does not have symbols, its locations should not include lines and functions.