parca debug-info upload #4648
Open
parca debug-info upload #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev-grafanista
force-pushed
the
debuginfo-upload
branch
5 times, most recently
from
d202551 to
8577f33
Compare
korniltsev-grafanista
force-pushed
the
debuginfo-upload
branch
from
8577f33 to
5c053a7
Compare
Co-Authored-By: Claude Opus 4.5 <[email protected]>
korniltsev-grafanista
changed the title
korniltsev-grafanista
requested review from
a team,
aleks-p,
alsoba13,
marcsanmi and
simonswine
as code owners
Add debug-level logging to help troubleshoot debuginfo upload issues: - Log ShouldInitiateUpload results (build_id, decision, reason) - Log Upload gRPC results (success with size, or failure with error) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Debuginfod fetching is now handled in the symbolizer instead of in the parca debuginfo store. This removes the debuginfod client implementation, related tests, and test fixtures from the parca/debuginfo package. Also removes tenant ID handling from the debuginfo store since it's not needed for this use case. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…test Refactor the store test to use an HTTP/2 server with h2c and the util.AuthenticateUser middleware instead of a direct gRPC server. This better reflects the production setup where requests go through HTTP middleware for tenant authentication. Co-Authored-By: Claude Opus 4.5 <[email protected]>
marcsanmi
reviewed
Jan 20, 2026
| span.SetAttributes(attribute.String("upload_id", uploadID)) | ||
|
|
||
| if err := s.upload(ctx, buildID, uploadID, typ, r); err != nil { | ||
| level.Debug(s.logger).Log( |
Contributor
There was a problem hiding this comment.
Should it be level.Error?
Comment on lines
+225
to
+230
| //case debuginfopb.DebuginfoUpload_STATE_PURGED: | ||
| // // Debuginfo was purged, allow re-uploading | ||
| // return &debuginfopb.ShouldInitiateUploadResponse{ | ||
| // ShouldInitiateUpload: true, | ||
| // Reason: ReasonDebuginfoPurged, | ||
| // }, nil |
| } | ||
|
|
||
| func (s *Symbolizer) fetch(ctx context.Context, buildID string) (io.ReadCloser, error) { | ||
| if r, err := s.fetchFromParca(ctx, buildID); err == nil { |
Contributor
There was a problem hiding this comment.
Do you think is worth considering adding a background job to pre-convert uploaded debug info to Lidia format right after upload so the first symbolization request would be faster? Maybe it's just a premature optimization
|
|
||
| t := noop.Tracer{} | ||
| l = log.With(l, "component", "debug-info") | ||
| bucket = objstore.NewPrefixedBucket(bucket, symbolizer.BucketPrefixParcaDebugInfo) |
Contributor
There was a problem hiding this comment.
I think we don't have a cleanup mechanism to control unbounded growth (neither for symbolizer path). Could it be an issue?
| func (c *LRUCache[K, V]) Get(key K) (V, bool) { | ||
| c.mtx.RLock() | ||
| defer c.mtx.RUnlock() | ||
| return c.lru.Get(key) |
Contributor
There was a problem hiding this comment.
Could it be a race? I think .Get modifies internal state with MoveToFront while using a RLock
Co-authored-by: Marc Sanmiquel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the code from https://github.com/parca-dev/parca/tree/main/pkg/debuginfo into pyroscope and integrates with the existing distributors and symbolizer
The parca's
debuginfouploads debug info binaries to a separate bucket subdir.The symbolizer later uses the new subdir as the source for debug info binaries as an alternative to debuginfod.