Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histograms dashboard display avg VUs instead of sum #168

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

brunocascio
Copy link
Contributor

@brunocascio brunocascio commented Aug 15, 2024

Hisotgram Dashboard display the average amount of vus across all the instances.
The expected amount of values should be sum() of them (like the non-histogram dashboard)

@brunocascio brunocascio requested a review from a team as a code owner August 15, 2024 18:01
@brunocascio brunocascio requested review from mstoykov and olegbespalov and removed request for a team August 15, 2024 18:01
@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

@olegbespalov olegbespalov requested a review from ppcano August 21, 2024 08:34
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this dashboards were done by @ppcano I am deferring to your review. But it does sound logical.

Thanks for the contribution @brunocascio 🙇

@olegbespalov olegbespalov merged commit bb07c3d into grafana:main Aug 28, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants