More updates for 7.0.0-M1 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Asciidoctor to `4.0.4`, enabling the removal of the transitive dependency workaround and the Ruby repository configuration.
Add an `.sdkmanrc` file to define JDK version for consistent development environment setup.
- Extract java configuration - Combine test configuration to one file
This prevents the Grails Gradle Plugin from unnecessarily excluding `slf4j-simple` in the generated POMs (grails/grails-gradle-plugin#222)
jdaugherty
reviewed
Jan 9, 2025
plugin/build.gradle
Outdated
|
|
||
| repositories { | ||
| maven { url = 'https://repo.grails.org/grails/core' } | ||
| mavenCentral() | ||
| if (System.getenv('GITHUB_MAVEN_PASSWORD') && !grailsVersion.endsWith('-SNAPSHOT')) { | ||
| logger.lifecycle('Adding Milestone Grails Core Repo for project {}', project.name) | ||
| logger.lifecycle('Adding Grails Core Milestone Repo for project {}', project.name) |
There was a problem hiding this comment.
This really is the staging repo - it can be used for release or milestone
| @@ -3,9 +3,8 @@ buildscript { | |||
| maven { url = 'https://repo.grails.org/grails/core' } | |||
| } | |||
| dependencies { | |||
| classpath "org.grails:grails-bom:$grailsVersion" | |||
| classpath platform("org.grails:grails-bom:$grailsVersion") | |||
There was a problem hiding this comment.
Why is the bom required on the gradle classpath?
There was a problem hiding this comment.
Without it, I have to set the version of asset-pipeline-gradle.
There was a problem hiding this comment.
This is genius! We could remove the assetPipelinePluginVersion properties in several projects by doing this too.
matrei
force-pushed
the
matrei/more-update-for-m1
branch
from
5827b2b to
16fb710
Compare
jdaugherty
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.