[CI] Ubuntu 24.04 and 22.04 part 6/6 #2031
Conversation
woju
force-pushed
the
woju/noble-stack-5
branch
from
5fa6688 to
bc104e4
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, 1 of 1 files at r3, 14 of 14 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits line 29 at r3:
enable (typo)
woju
force-pushed
the
woju/noble-stack-4
branch
from
2a9d374 to
aff535f
Compare
Signed-off-by: Wojtek Porczyk <[email protected]>
woju
force-pushed
the
woju/noble-stack-5
branch
from
bc104e4 to
0b85898
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, 15 of 31 files at r5, 8 of 16 files at r6, 1 of 1 files at r7, 14 of 14 files at r8, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @woju)
-- commits line 7 at r6:
I think this commit is missing the removal of 20.04 from check-python-platlib.jenkinsfile?
There was a problem hiding this comment.
Reviewed 8 of 16 files at r6, 1 of 1 files at r7, 14 of 14 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @woju)
woju
force-pushed
the
woju/noble-stack-5
branch
from
0b85898 to
60be07d
Compare
There was a problem hiding this comment.
Reviewable status: 18 of 36 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @dimakuv and @mkow)
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
enable(typo)
Done.
Previously, mkow (Michał Kowalczyk) wrote…
I think this commit is missing the removal of 20.04 from
check-python-platlib.jenkinsfile?
Done. Yes, and also missed removing the dockerfile.
There was a problem hiding this comment.
Reviewed 3 of 18 files at r9, 1 of 1 files at r10, 14 of 14 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required) (waiting on @mkow)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, 8 of 16 files at r6, 3 of 18 files at r9, 1 of 1 files at r10, 14 of 14 files at r11, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mkow and @woju)
-- commits line 11 at r11:
-> answers
Code quote:
anwers
The problem is, if this test is run inside VM, it is prone to randomly failing. It should have been disabled altogether in the previous commit. Fixes: f03afa0 ("[LibOS/tests] Fix timing issues on certain LTP tests") Signed-off-by: Wojtek Porczyk <[email protected]>
woju
force-pushed
the
woju/noble-stack-5
branch
from
60be07d to
ae86a08
Compare
There was a problem hiding this comment.
Reviewed 1 of 35 files at r12, 11 of 19 files at r13, 1 of 1 files at r14, 14 of 14 files at r15, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (1 more required) (waiting on @mkow and @woju)
This coincides with IAS EOL, which happened on 1 October 2024. Our CI runners for Focal used to use EPID developer key, and those were disabled. As of this writing, IAS answers 401 to our key. See also: https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/resources/sgx-ias-using-epid-eol-timeline.html Moving those runners to DCAP environment would require some work for very little value. Focal is the third newest LTS at the time of this writing, so not supported anyway according to our policy. Therefore we just disable Ubuntu 20.04 LTS altogether. Signed-off-by: Wojtek Porczyk <[email protected]>
This reverts commit 88d0ade. The pipelines for 20.04 were removed in previous commit, so time to enable those tests again. Signed-off-by: Wojtek Porczyk <[email protected]>
Signed-off-by: Wojtek Porczyk <[email protected]>
woju
force-pushed
the
woju/noble-stack-5
branch
from
ae86a08 to
fdcf72c
Compare
There was a problem hiding this comment.
Reviewed 1 of 35 files at r12, 11 of 19 files at r13, 1 of 1 files at r17, 14 of 14 files at r18, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Description of the changes
See #2026 for rationale. This PR concludes the series.
How to test this PR?
git fetch && git diff origin/woju/ubuntu-noble-3 origin/woju/noble-stack-5(should be empty).This change is